Skip to content

Feature: extend advanced settings with more options & inherit app defaults #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michelroegl-brunner merged 3 commits into from
Dec 9, 2025
Merged

Feature: extend advanced settings with more options & inherit app defaults #9776

michelroegl-brunner merged 3 commits into from
Dec 9, 2025
+512 −60

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Dec 8, 2025

✍️ Description

1.) inherit app defaults in advanced settings wizard

  • All var_* values from CT scripts now pre-populate wizard fields
  • Added TUN/TAP support step (Step 19) with var_tun default
  • Added Nesting support step (Step 20) with var_nesting default
  • FUSE, GPU, Verbose now show '(App default: X)' hints
  • Nesting feature now user-configurable (was hardcoded)
  • MAX_STEP increased from 20 to 22
  • All feature flags (FUSE, TUN, GPU, Nesting) saved to app defaults
  • Summary shows all features including TUN and Nesting status

2.)
Advanced Settings Wizard (28 steps):

  • Step 18: FUSE Support (inherits var_fuse)
  • Step 19: TUN/TAP Support (inherits var_tun)
  • Step 20: Nesting Support (inherits var_nesting)
  • Step 21: GPU Passthrough (inherits var_gpu)
  • Step 22: Keyctl Support (inherits var_keyctl)
  • Step 23: APT Cacher Proxy (inherits var_apt_cacher/var_apt_cacher_ip)
  • Step 24: Container Timezone (inherits var_timezone)
  • Step 25: Container Protection (inherits var_protection)
  • Step 26: Device Node Creation (inherits var_mknod)
  • Step 27: Mount Filesystems (inherits var_mount_fs)
  • Step 28: Verbose Mode & Confirmation

3.)
pre-fill timezone with host timezone in advanced settings

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@MickLesk
feat: inherit app defaults in advanced settings wizard
8b94082 
- All var_* values from CT scripts now pre-populate wizard fields
- Added TUN/TAP support step (Step 19) with var_tun default
- Added Nesting support step (Step 20) with var_nesting default
- FUSE, GPU, Verbose now show '(App default: X)' hints
- Nesting feature now user-configurable (was hardcoded)
- MAX_STEP increased from 20 to 22
- All feature flags (FUSE, TUN, GPU, Nesting) saved to app defaults
- Summary shows all features including TUN and Nesting status
@MickLesk
feat: complete advanced settings with all var_* options
6bf6da0 
Advanced Settings Wizard (28 steps):
- Step 18: FUSE Support (inherits var_fuse)
- Step 19: TUN/TAP Support (inherits var_tun)
- Step 20: Nesting Support (inherits var_nesting)
- Step 21: GPU Passthrough (inherits var_gpu)
- Step 22: Keyctl Support (inherits var_keyctl)
- Step 23: APT Cacher Proxy (inherits var_apt_cacher/var_apt_cacher_ip)
- Step 24: Container Timezone (inherits var_timezone)
- Step 25: Container Protection (inherits var_protection)
- Step 26: Device Node Creation (inherits var_mknod)
- Step 27: Mount Filesystems (inherits var_mount_fs)
- Step 28: Verbose Mode & Confirmation

All var_* from CT scripts now pre-populate wizard fields with '(App default: X)' hints.

Documentation:
- New BUILD_FUNC_ADVANCED_SETTINGS.md with full wizard reference
- Updated BUILD_FUNC_ENVIRONMENT_VARIABLES.md with all feature flags
- Updated README.md with new documentation link
@MickLesk
fix: pre-fill timezone with host timezone in advanced settings
b83ac2b
@MickLesk MickLesk marked this pull request as ready for review December 9, 2025 14:24
@MickLesk MickLesk requested a review from a team as a code owner December 9, 2025 14:24
@MickLesk
Copy link
Member Author

MickLesk commented Dec 9, 2025

Tested and worked fine in VED; feel free to test it @community-scripts/contributor
mode=advanced bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVED/raw/branch/main/ct/debian.sh)"

Example:
image

image image image

@MickLesk MickLesk changed the title Feature/advanced settings inherit app defaults Feature: extend advanced settings with more options & inherit app defaults Dec 9, 2025
@michelroegl-brunner michelroegl-brunner merged commit bea9a62 into main Dec 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tremor021 tremor021 tremor021 approved these changes

@michelroegl-brunner michelroegl-brunner michelroegl-brunner approved these changes

@CrazyWolf13 CrazyWolf13 CrazyWolf13 approved these changes

Assignees

No one assigned

Labels

core documentation feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MickLesk @tremor021 @michelroegl-brunner @CrazyWolf13